Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up temporary clone paths by default #113

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

zackproser
Copy link
Contributor

Description

Fixes #98 .

These changes allow git-xargs to clean up the temporary file paths where it clones repositories. By default, git-xargs will now delete the paths after processing the repo. If you wish to preserve your local clones, pass the new --keep-cloned-repositories flag.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

By default, git-xargs will now delete the temporary file paths where it clones your repositories in order to run commands on them. This should help prevent git-xargs from taking up too much space. If you wish to preserve local clone paths going forward, pass the new --keep-cloned-repositories flag.

Migration Guide

- Add flag (--keep-cloned-repositories) to preserve them
Copy link

@Etiene Etiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (but not sure if my approval will count)
edit: it did not

@zackproser
Copy link
Contributor Author

LGTM! (but not sure if my approval will count) edit: it did not

Thank you @Etiene! 🙌

Copy link
Contributor

@marinalimeira marinalimeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pliniodng
Copy link

Hey @zackproser, thanks for taking the time and writing the PR. Looks good, thanks!

@zackproser
Copy link
Contributor Author

Thanks for reviews! Going to merge this in now.

@zackproser zackproser merged commit 1ba5873 into master Feb 10, 2023
@zackproser zackproser deleted the feature/98-cleanup-temp-clone-paths branch February 10, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of Clone Repositories into temporary folders
4 participants