Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIS Compliance Guide Improvements #442

Merged
merged 7 commits into from
Jul 6, 2021

Conversation

rhoboat
Copy link
Contributor

@rhoboat rhoboat commented Jun 16, 2021

A friend of #441 .

Issues covered from that PR:

Cleanup tasks:

  • Change accounts declaration from accounts = {x,y,z} to accounts = jsondecode(file("accounts.json")) See comment
  • Update local.accounts["stage"] to local.accounts.stage to be consistent across guides (e.g. the LZ guide) See comment
  • Review references of accounts such as in this comment
  • Replace name_prefix = "stage-logs" with something unique like name_prefix = "<SOME UNIQUE IDENTIFIER>-logs" - see this comment
  • Removed one case of infrastructure-modules being referenced.
  • Move more stuff into common.hcl.

Readability tasks:

  • Introduce a common.hcl to hold hard-coded values that are repeated across the code examples - See this comment

@netlify
Copy link

netlify bot commented Jun 16, 2021

✔️ Deploy Preview for keen-clarke-470db9 ready!

🔨 Explore the source changes: 68e8449

🔍 Inspect the deploy log: https://app.netlify.com/sites/keen-clarke-470db9/deploys/60dc99b761f562000705978b

😎 Browse the preview: https://deploy-preview-442--keen-clarke-470db9.netlify.app

@rhoboat rhoboat requested review from ina-stoyanova and removed request for josh-padnick, tsmit291, oredavids and eak12913 June 16, 2021 22:54
Copy link
Contributor

@ina-stoyanova ina-stoyanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. I think once we are clear on Jim's comments, this should be good to go! Thanks for picking this up, Rho! 🙇

@ina-stoyanova
Copy link
Contributor

Could I get another set of 👀 on this? The last relevant changes should resolve the comments above.

@ina-stoyanova
Copy link
Contributor

This is ready for another look @marinalimeira when you can :)

Copy link
Contributor

@marinalimeira marinalimeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ina-stoyanova
Copy link
Contributor

Thank you @marinalimeira! Merging now 🎉

@ina-stoyanova ina-stoyanova merged commit e4ddc24 into master Jul 6, 2021
@ina-stoyanova ina-stoyanova deleted the rho/cis-compliance-guide-fixes branch July 6, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants