-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIS Compliance Guide Improvements #442
Conversation
✔️ Deploy Preview for keen-clarke-470db9 ready! 🔨 Explore the source changes: 68e8449 🔍 Inspect the deploy log: https://app.netlify.com/sites/keen-clarke-470db9/deploys/60dc99b761f562000705978b 😎 Browse the preview: https://deploy-preview-442--keen-clarke-470db9.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. I think once we are clear on Jim's comments, this should be good to go! Thanks for picking this up, Rho! 🙇
Could I get another set of 👀 on this? The last relevant changes should resolve the comments above. |
This is ready for another look @marinalimeira when you can :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @marinalimeira! Merging now 🎉 |
A friend of #441 .
Issues covered from that PR:
Cleanup tasks:
accounts = {x,y,z}
toaccounts = jsondecode(file("accounts.json"))
See commentlocal.accounts["stage"]
tolocal.accounts.stage
to be consistent across guides (e.g. the LZ guide) See commentname_prefix = "stage-logs"
with something unique likename_prefix = "<SOME UNIQUE IDENTIFIER>-logs"
- see this commentinfrastructure-modules
being referenced.common.hcl
.Readability tasks:
common.hcl
to hold hard-coded values that are repeated across the code examples - See this comment