Add priorityclassname Support and Test #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryehowell Could you take a look at this when you get a chance? 'cc @gitsstewart |
|
Hey @reynoldsme, thanks for the contribution! I'm wrapping up a couple other PR's at the moment, but will review this next. It probably won't be until tomorrow though. I went ahead and kicked off the CI build as well. |
ryehowell
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #159.
This PR introduces suport for priorityClassName and adds the
TestK8sServicePriorityClassNametest.TODOs
Read the Gruntwork contribution guidelines.
*documented in values.yaml. I'm happy to add something to
/charts/k8s-service/README.mdif that is determined to be necessary.Release Notes (draft)
Added support for priorityClassName.