Bug fixes in eks cleanup code

[rhoboat]

Test run on terraform-aws-eks revealed a bug in the logic in our cleanup. This attempts to fix that.

[yorinasub17]

This LGTM, assuming my interpretation is correct. Basically the bug was that we were wrapping the error in the stack traced error struct, so the IsAwsErr checks were failing?

[rhoboat]

The bug was that we were throwing errors that the ENI was NotFound, from within requestDetach, when actually, we have a place that catches that error in the calling function:

kubergrunt/eks/cleanup.go

Lines 183 to 185 in ca93476

	case isNIAttachmentNotFoundErr(err):
	logger.Infof("Network interface %s is detached.", aws.StringValue(ni.NetworkInterfaceId))
	continue

[rhoboat]

Sorry, need another approval, couldn't resist improving some comments.

[yorinasub17]

The bug was that we were throwing errors that the ENI was NotFound, from within requestDetach, when actually, we have a place that catches that error in the calling function:

Got it! I think we are saying the same thing.