Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupName is only supported in default VPC and EC2-classic #106

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

yorinasub17
Copy link
Contributor

If you look at the description for GroupName field on DeleteSecurityGroup, it will indicate that you should only set it for EC2-classic or the default VPC, neither of which we are using with EKS. Setting this seems harmless but it actually causes an error if there is no Default VPC in the account:

ERROR: VPCIdNotSpecified: No default VPC for this user. GroupName is only supported for EC2-Classic and default VPC.
status code: 400, request id: 6b6221a7-f5ba-4700-b46a-56cb6d88e44d

https://docs.aws.amazon.com/sdk-for-go/api/service/ec2/#DeleteSecurityGroupInput

Copy link
Contributor

@rhoboat rhoboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was one of the pieces I was not sure about when I wrote it. Because I had both values, GroupId and GroupName, I thought what would be the risk in using both. But we don't need both, and this should work.

@yorinasub17
Copy link
Contributor Author

Build passed, so merging in!

@yorinasub17 yorinasub17 merged commit b696756 into master Dec 19, 2020
@yorinasub17 yorinasub17 deleted the yori-groupnameissue branch December 19, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants