Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks #22

Merged
merged 1 commit into from Feb 7, 2019
Merged

Minor tweaks #22

merged 1 commit into from Feb 7, 2019

Conversation

yorinasub17
Copy link
Contributor

This addresses the issues you brought up on the call @robmorgan:

  • Add note in README about how to build from source
  • Remove the silly check for kubergrunt in... kubergrunt... 馃槄

Copy link
Member

@robmorgan robmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

go build -o kubergrunt ./cmd
```


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 馃憤

@@ -293,9 +293,6 @@ func deployHelmServer(cliContext *cli.Context) error {
if err := shell.CommandInstalledE("helm"); err != nil {
return err
}
if err := shell.CommandInstalledE("kubergrunt"); err != nil {
return err
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 馃憤

@yorinasub17
Copy link
Contributor Author

Merging!

@yorinasub17 yorinasub17 merged commit 371cfbe into master Feb 7, 2019
@yorinasub17 yorinasub17 deleted the yori-minor-tweaks branch February 7, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants