Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #85

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Update CODEOWNERS #85

merged 1 commit into from
Oct 25, 2022

Conversation

zackproser
Copy link
Contributor

Description

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

@zackproser zackproser mentioned this pull request Oct 24, 2022
Closed
pete0emerson
pete0emerson approved these changes Oct 24, 2022
View reviewed changes
Copy link

@pete0emerson pete0emerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zackproser
Copy link
Contributor Author

Thanks for reviews! Going to merge this in now.

@zackproser zackproser merged commit 8c94dc3 into master Oct 25, 2022
@zackproser zackproser deleted the update-codeowners branch October 25, 2022 10:23
joelbcastillo added a commit to Hyperfine/pre-commit that referenced this pull request Oct 25, 2023
@joelbcastillo
Merge branch 'master' of ssh://github.com/gruntwork-io/pre-commit
37870a1 
* 'master' of ssh://github.com/gruntwork-io/pre-commit:
  [skip ci] Removing former Grunts (gruntwork-io#101)
  [skip ci] git-xargs programmatic commit (gruntwork-io#99)
  tflint has deprecated the 'tflint FILE/DIR' syntax (gruntwork-io#95)
  Add support to use args in tflint (gruntwork-io#92)
  Add a golangci-lint hook (gruntwork-io#93)
  Add sentinel fmt hook (gruntwork-io#89)
  Ignore hash links (gruntwork-io#86)
  Update CODEOWNERS (gruntwork-io#85)
  Update deprecated circleci images to latest (gruntwork-io#72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete0emerson pete0emerson pete0emerson approved these changes

@marinalimeira marinalimeira marinalimeira approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zackproser @pete0emerson @marinalimeira