Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

[IAC-1677] Replace gofmt with goimports #125

Merged
merged 3 commits into from Jul 15, 2021
Merged

[IAC-1677] Replace gofmt with goimports #125

merged 3 commits into from Jul 15, 2021

Conversation

ina-stoyanova
Copy link
Contributor

Replace gofmt with goimports in the pre-commit configuration. Note: This PR was opened using git-xargs.

zackproser
zackproser approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures appear unrelated to changes.

@marinalimeira
Copy link
Contributor 

Error: �[0m�[0m�[1mError waiting to create Router: Error waiting for Creating Router: Quota 'ROUTERS' exceeded.  Limit: 10.0 globally.

This is the latest test failure, not related to the changes.

@marinalimeira marinalimeira merged commit 4442011 into master Jul 15, 2021
@marinalimeira marinalimeira deleted the update-to-goimports branch July 15, 2021 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zackproser zackproser zackproser approved these changes

@robmorgan robmorgan Awaiting requested review from robmorgan robmorgan is a code owner

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

Assignees

@marinalimeira marinalimeira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ina-stoyanova @marinalimeira @zackproser