Upgrade Examples and tests to use Helm 3 #88

autero1 · 2020-04-04T10:08:39Z

This PR updates the tests and examples to use Helm 3 instead of Helm 2 with Tiller. As a result, one of the examples was removed as redundant and the new gke-basic-helm was moved to the root of the repo.

The TestGKEBasicHelm test case has some redundancy, as both the Terraform example and the test deploy a chart, but I decided to leave it that way - primarily because I felt it made the example itself much better, because the user actually gets to interact with the cluster.

Tests pass locally, the only question mark for me is how they behave in CircleCI.

Fixes #82

autero1 · 2020-04-07T13:25:41Z

Looks like the tests failed. I'll try and see tomorrow what the problem was.

robmorgan

This is looking pretty good to me. My only question is should the default example in the root of the repo be a private GKE cluster? I believe that's what we had originally? Is it too hard to remotely install charts this way?

robmorgan · 2020-04-07T13:33:38Z

.circleci/config.yml

@@ -3,13 +3,12 @@ defaults: &defaults
  environment:
    GRUNTWORK_INSTALLER_VERSION: v0.0.21
    TERRATEST_LOG_PARSER_VERSION: v0.13.13
-    KUBERGRUNT_VERSION: v0.3.9
-    HELM_VERSION: v2.11.0
+    HELM_VERSION: v3.1.0


I might update this to v3.1.2 to match terraform-aws-eks.

autero1 · 2020-04-07T14:05:53Z

My only question is should the default example in the root of the repo be a private GKE cluster? I believe that's what we had originally?

The original root example was the private Tiller example. That's why I opted for the Helm example as the new root.

robmorgan · 2020-04-07T14:21:58Z

@autero1 sure but is it possible to do a Helm example in the new root with a private cluster?

autero1 · 2020-04-07T15:16:31Z

Ah, you're right... 😄 It was indeed a private cluster. I'll change that and fix the tests.

zackproser

Looking solid 👍 Left some nits.

examples/gke-basic-helm/README.md

zackproser · 2020-04-07T15:23:16Z

examples/gke-basic-helm/README.md

+Forwarding from [::1]:8080 -> 8080
+```
+
+You can now access the deployed service by opening your web browser to `http://localhost:8088`.


Did you mean for this to be http:localhost:8080 ?

Good catch!

zackproser · 2020-04-07T15:23:34Z

examples/gke-basic-helm/README.md

@@ -0,0 +1,88 @@
+# GKE Basic Helm Example


Awesome docs 👍

zackproser · 2020-04-07T15:25:48Z

main.tf

-  tiller_tls_key_file_name = "tls.pem"
-
-  dependencies = [null_resource.tiller_tls_certs.id, kubernetes_cluster_role_binding.user.id]
+data "helm_repository" "bitnami" {


NIT: maybe worth a comment about what is happening here - would probably be helpful for folks new to Helm concepts.

Specifically that its going to look up a chart from a chart repository.

NIT: There is actually a critical issue with this data source (hashicorp/terraform-provider-helm#438 and hashicorp/terraform-provider-helm#416), and they are considering removing it entirely. I've found that it is much more robust and stable to directly use the repo URL in the repository attribute of the helm_release resource instead.

Thanks @yorinasub17 for pointing this out. I'll fix this!

Co-Authored-By: Zack Proser <zackproser@gmail.com>

…ke into helm3_upgrade

autero1 · 2020-04-08T07:48:35Z

I bumped a lot of tool versions, but don't know if it fixed the test issue.

A more confusing thing was an issue with the network module. Since v0.3.0 the terraform-google-network changed NAT routing from public to private. I used v0.4.0 in the example (other examples untouched) and I initially failed to install any charts, because the nodes did not have internet connectivity and could not pull the images.

After some experimentation, the example is successfully deployed to the private subnet, with private network tag, so the cluster is truly private.

Decided not to change the network module version for the other examples to not bloat the PR even further.

robmorgan

@autero1

A more confusing thing was an issue with the network module. Since v0.3.0 the terraform-google-network changed NAT routing from public to private. I used v0.4.0 in the example (other examples untouched) and I initially failed to install any charts, because the nodes did not have internet connectivity and could not pull the images.

Actually it appears we'd always had a bug in our vpc-network module. So I shipped gruntwork-io/terraform-google-network#53 in v0.3.0, which enabled NAT routing for private subnetworks instead of the public one (I assumed the public subnetwork doesn't need NAT routing anyhow).

Sorry if that was confusing, but I think we have the right behaviour now. Please correct me if I'm wrong:

Private Subnetworks with NAT routing enabled so the Nodes have internet connectivity.
A Private GKE Cluster with a Helm chart deployed.

main.tf

robmorgan · 2020-04-09T08:46:50Z

main.tf

-# This is an example of how to use the gke-cluster module to deploy a private Kubernetes cluster in GCP
+# DEPLOY A GKE PUBLIC CLUSTER IN GOOGLE CLOUD PLATFORM
+# This is an example of how to use the gke-cluster module to deploy a public Kubernetes cluster in GCP with a
+# Load Balancer in front of it.


Suggested change

# Load Balancer in front of it.

robmorgan · 2020-04-09T08:58:19Z

main.tf

  # See the network access tier table for full details:
  # https://github.com/gruntwork-io/terraform-google-network/tree/master/modules/vpc-network#access-tier
-  subnetwork = module.vpc_network.public_subnetwork
+  subnetwork = module.vpc_network.private_subnetwork


test/go.mod

Co-Authored-By: Rob Morgan <robbym@gmail.com>

autero1 · 2020-04-09T09:47:06Z

Private Subnetworks with NAT routing enabled so the Nodes have internet connectivity.
A Private GKE Cluster with a Helm chart deployed.

That is correct. And I agree that with the fix in the network module, we now have correct behaviour.

I applied the fixes you suggested.

robmorgan · 2020-04-09T14:01:00Z

@autero1 cool man, I'll kick off the tests again

robmorgan · 2020-04-09T14:51:01Z

@autero1 It looks like they passed in https://circleci.com/gh/gruntwork-io/terraform-google-gke/457. Ok to merge?

autero1 · 2020-04-09T20:41:04Z

Ok to merge! Though the tests seemed to fail until you made final tweaks to the PR branch. Will you merge those after you merge this PR?

robmorgan · 2020-04-10T13:39:07Z

@autero1 yep, I'll merge my branch. It will take all of your commits, apply mine on top and close this PR!

autero1 added 3 commits April 4, 2020 12:22

Upgrade examples and tests to Helm 3

53db10f

Comment skips

42cba06

Use GetResourceCount

e1bacbf

autero1 requested review from robmorgan and yorinasub17 as code owners April 4, 2020 10:08

autero1 added 2 commits April 4, 2020 13:20

Fix go mod caching

473a8f0

Update Go Modules documentation

5150dda

robmorgan reviewed Apr 7, 2020

View reviewed changes

zackproser reviewed Apr 7, 2020

View reviewed changes

autero1 and others added 8 commits April 7, 2020 18:50

[skip ci] Update examples/gke-basic-helm/README.md

a67ed0f

Co-Authored-By: Zack Proser <zackproser@gmail.com>

Add Helm repo documentation

570a0af

Fix port num in documentation

465637f

Merge branch 'helm3_upgrade' of github.com:autero1/terraform-google-g…

00cb38e

…ke into helm3_upgrade

Switch to private cluster

9cb0b61

Bump versions and fix checksum path

7135f2f

Try different setting go src path

3e48277

Fix issue with later network -module and skip helm repo data source

36b0490

robmorgan reviewed Apr 9, 2020

View reviewed changes

autero1 and others added 3 commits April 9, 2020 12:43

Update main.tf

8c434a3

Co-Authored-By: Rob Morgan <robbym@gmail.com>

Update main.tf

f6771b8

Co-Authored-By: Rob Morgan <robbym@gmail.com>

Update test/go.mod

a781d0d

Co-Authored-By: Rob Morgan <robbym@gmail.com>

robmorgan merged commit a781d0d into gruntwork-io:master Apr 10, 2020

mogul mentioned this pull request Apr 18, 2020

Approved Solr service available to cloud.gov apps GSA/data.gov#1379

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Examples and tests to use Helm 3 #88

Upgrade Examples and tests to use Helm 3 #88

autero1 commented Apr 4, 2020

autero1 commented Apr 7, 2020

robmorgan left a comment

robmorgan Apr 7, 2020

autero1 commented Apr 7, 2020

robmorgan commented Apr 7, 2020

autero1 commented Apr 7, 2020

zackproser left a comment

zackproser Apr 7, 2020

autero1 Apr 7, 2020

zackproser Apr 7, 2020

zackproser Apr 7, 2020

zackproser Apr 7, 2020

yorinasub17 Apr 8, 2020 •

edited

Loading

autero1 Apr 8, 2020

autero1 commented Apr 8, 2020 •

edited

Loading

robmorgan left a comment

robmorgan Apr 9, 2020

robmorgan Apr 9, 2020

autero1 commented Apr 9, 2020

robmorgan commented Apr 9, 2020

robmorgan commented Apr 9, 2020

autero1 commented Apr 9, 2020

robmorgan commented Apr 10, 2020

Upgrade Examples and tests to use Helm 3 #88

Upgrade Examples and tests to use Helm 3 #88

Conversation

autero1 commented Apr 4, 2020

autero1 commented Apr 7, 2020

robmorgan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

autero1 commented Apr 7, 2020

robmorgan commented Apr 7, 2020

autero1 commented Apr 7, 2020

zackproser left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yorinasub17 Apr 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

autero1 commented Apr 8, 2020 • edited Loading

robmorgan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

autero1 commented Apr 9, 2020

robmorgan commented Apr 9, 2020

robmorgan commented Apr 9, 2020

autero1 commented Apr 9, 2020

robmorgan commented Apr 10, 2020

yorinasub17 Apr 8, 2020 •

edited

Loading

autero1 commented Apr 8, 2020 •

edited

Loading