Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1904 Added protection check for "apply -destroy" invocation #1905

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Nov 6, 2021

Added protection check for "apply -destroy" invocation

Fix for: #1904

yorinasub17
yorinasub17 previously approved these changes Nov 8, 2021
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me kick off the build, and if it passes, we can merge this in!

@yorinasub17
Copy link
Contributor

@denis256
Copy link
Member Author

denis256 commented Nov 8, 2021

Updated test to copy work directory to a temporary location, sharing same fixture directory between tests and run destroy wasn't a good idea

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update LGTM and test passed so going to merge this in!

@yorinasub17 yorinasub17 merged commit b75131c into gruntwork-io:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants