Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go upgrade to 1.20 #2605

Merged
merged 2 commits into from Jun 15, 2023
Merged

Go upgrade to 1.20 #2605

merged 2 commits into from Jun 15, 2023

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Jun 15, 2023 •
edited

Description

Updated Go version to last supported release

Included changes:

  • updated used docker image with go 1.20
  • updated go version used in windows tests
  • updated formatting on files to match go 1.20

image

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated used Go version to 1.20

Migration Guide

N/A

@denis256 denis256 changed the title [WIP] Upgrade to go 1.20 Go upgrade to 1.20 Jun 15, 2023
@denis256 denis256 marked this pull request as ready for review June 15, 2023 08:53
@denis256 denis256 merged commit 1d18109 into master Jun 15, 2023
3 checks passed
@denis256 denis256 deleted the feature/go-1-20 branch June 15, 2023 20:52
levkohimins pushed a commit that referenced this pull request Jun 16, 2023
Revert "Go upgrade to 1.20 (#2605)"
b8db741 
This reverts commit 1d18109.
levkohimins pushed a commit that referenced this pull request Jun 16, 2023
Revert "Go upgrade to 1.20 (#2605)"
d71dfee 
This reverts commit 1d18109.
levkohimins pushed a commit that referenced this pull request Jun 16, 2023
Revert "Revert "Go upgrade to 1.20 (#2605)""
6e2676f 
This reverts commit d71dfee.
levkohimins added a commit that referenced this pull request Aug 9, 2023
@levkohimins @denis256
Refactoring cli related code (#2608)
73d2c83 
* add auxiliary packages

* improvement cli package

* cli package improvement

* fix issues in cli package

* add flag type int64

* cli flag improvement

* cli package improvement

* fix loop

* add args in cli

* add cli flag

* update cli flag

* refactoring cli code

* fix logger

* template improvements

* fix options

* fix minor issue

* cli package improvement

* add command to cli package

* remove commented code

* add command action

* code refactoring

* cli args improvements

* cli command improvements

* restruct command files

* code refactoring

* fix build error

* fix help template

* bool type improvement

* type improvements

* code refactoring cli package

* restruct cli folder

* restruct cli folder

* move app_test file

* move terraform_test file

* restruct folder

* beta implementation

* fix unit test

* code improvement

* fix unit test

* flag assignment improvement

* fix deprecated command help

* fix unit tests

* fix tests

* fix test

* update go version

* fix panic

* fix config path

* fix arg parsing

* fix integration test

* fix runall command

* add disable log colors

* fix render-json command

* fix TerraformCommand

* code improvements

* get rid of repetitive code

* fix auto init

* add var common flags

* fix test

* fix command flags append

* add subcommands for run-all help

* fix subcommands in run-all

* code improvement

* code documentation

* fix help display

* fix help display

* fix integration test

* Revert "Go upgrade to 1.20 (#2605)"

This reverts commit 1d18109.

* revert TestTerragruntOutputFromRemoteState

* Increased executor size

* Testing size

* Update resource

* Revert "Revert "Go upgrade to 1.20 (#2605)""

This reverts commit d71dfee.

* fix integration tst

* fix integration test

* fix test

* fix test

* fix review remarks

* cli package improvement

* fix unit test

* cli package improvement

* add showVersion func

* add unit tests

* add unit tests

* cli improvement

* cli unit tests

* cli unit test

* update comment

* refactor: merge PR 'Add a "output-module-groups" command #2130'

* chore: get rid of empty file

* chore: backwards compatibility for `non-interactive` env var

* chore: fix gram

* fix: pr remarks

* fix: makefile

* fix: pr remarks

---------

Co-authored-by: Levko Burburas <levko.burburas@biptec.com>
Co-authored-by: Denis O <denis.o@linux.com>
Co-authored-by: Levko Himins <levkohimins@Levkos-Air-2.lan>
Co-authored-by: Levko Himins <levkohimins@beid.lan>
hugorut pushed a commit to infracost/terragrunt that referenced this pull request Oct 10, 2023
@levkohimins @denis256 @hugorut
Refactoring cli related code (gruntwork-io#2608)
a354068 
* add auxiliary packages

* improvement cli package

* cli package improvement

* fix issues in cli package

* add flag type int64

* cli flag improvement

* cli package improvement

* fix loop

* add args in cli

* add cli flag

* update cli flag

* refactoring cli code

* fix logger

* template improvements

* fix options

* fix minor issue

* cli package improvement

* add command to cli package

* remove commented code

* add command action

* code refactoring

* cli args improvements

* cli command improvements

* restruct command files

* code refactoring

* fix build error

* fix help template

* bool type improvement

* type improvements

* code refactoring cli package

* restruct cli folder

* restruct cli folder

* move app_test file

* move terraform_test file

* restruct folder

* beta implementation

* fix unit test

* code improvement

* fix unit test

* flag assignment improvement

* fix deprecated command help

* fix unit tests

* fix tests

* fix test

* update go version

* fix panic

* fix config path

* fix arg parsing

* fix integration test

* fix runall command

* add disable log colors

* fix render-json command

* fix TerraformCommand

* code improvements

* get rid of repetitive code

* fix auto init

* add var common flags

* fix test

* fix command flags append

* add subcommands for run-all help

* fix subcommands in run-all

* code improvement

* code documentation

* fix help display

* fix help display

* fix integration test

* Revert "Go upgrade to 1.20 (gruntwork-io#2605)"

This reverts commit 1d18109.

* revert TestTerragruntOutputFromRemoteState

* Increased executor size

* Testing size

* Update resource

* Revert "Revert "Go upgrade to 1.20 (gruntwork-io#2605)""

This reverts commit d71dfee.

* fix integration tst

* fix integration test

* fix test

* fix test

* fix review remarks

* cli package improvement

* fix unit test

* cli package improvement

* add showVersion func

* add unit tests

* add unit tests

* cli improvement

* cli unit tests

* cli unit test

* update comment

* refactor: merge PR 'Add a "output-module-groups" command gruntwork-io#2130'

* chore: get rid of empty file

* chore: backwards compatibility for `non-interactive` env var

* chore: fix gram

* fix: pr remarks

* fix: makefile

* fix: pr remarks

---------

Co-authored-by: Levko Burburas <levko.burburas@biptec.com>
Co-authored-by: Denis O <denis.o@linux.com>
Co-authored-by: Levko Himins <levkohimins@Levkos-Air-2.lan>
Co-authored-by: Levko Himins <levkohimins@beid.lan>
hugorut pushed a commit to infracost/terragrunt that referenced this pull request Oct 10, 2023
@levkohimins @denis256 @hugorut
Refactoring cli related code (gruntwork-io#2608)
9554bfe 
* add auxiliary packages

* improvement cli package

* cli package improvement

* fix issues in cli package

* add flag type int64

* cli flag improvement

* cli package improvement

* fix loop

* add args in cli

* add cli flag

* update cli flag

* refactoring cli code

* fix logger

* template improvements

* fix options

* fix minor issue

* cli package improvement

* add command to cli package

* remove commented code

* add command action

* code refactoring

* cli args improvements

* cli command improvements

* restruct command files

* code refactoring

* fix build error

* fix help template

* bool type improvement

* type improvements

* code refactoring cli package

* restruct cli folder

* restruct cli folder

* move app_test file

* move terraform_test file

* restruct folder

* beta implementation

* fix unit test

* code improvement

* fix unit test

* flag assignment improvement

* fix deprecated command help

* fix unit tests

* fix tests

* fix test

* update go version

* fix panic

* fix config path

* fix arg parsing

* fix integration test

* fix runall command

* add disable log colors

* fix render-json command

* fix TerraformCommand

* code improvements

* get rid of repetitive code

* fix auto init

* add var common flags

* fix test

* fix command flags append

* add subcommands for run-all help

* fix subcommands in run-all

* code improvement

* code documentation

* fix help display

* fix help display

* fix integration test

* Revert "Go upgrade to 1.20 (gruntwork-io#2605)"

This reverts commit 1d18109.

* revert TestTerragruntOutputFromRemoteState

* Increased executor size

* Testing size

* Update resource

* Revert "Revert "Go upgrade to 1.20 (gruntwork-io#2605)""

This reverts commit d71dfee.

* fix integration tst

* fix integration test

* fix test

* fix test

* fix review remarks

* cli package improvement

* fix unit test

* cli package improvement

* add showVersion func

* add unit tests

* add unit tests

* cli improvement

* cli unit tests

* cli unit test

* update comment

* refactor: merge PR 'Add a "output-module-groups" command gruntwork-io#2130'

* chore: get rid of empty file

* chore: backwards compatibility for `non-interactive` env var

* chore: fix gram

* fix: pr remarks

* fix: makefile

* fix: pr remarks

---------

Co-authored-by: Levko Burburas <levko.burburas@biptec.com>
Co-authored-by: Denis O <denis.o@linux.com>
Co-authored-by: Levko Himins <levkohimins@Levkos-Air-2.lan>
Co-authored-by: Levko Himins <levkohimins@beid.lan>
This was referenced Apr 16, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoonMoon1919 MoonMoon1919 MoonMoon1919 approved these changes

@zackproser zackproser Awaiting requested review from zackproser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@denis256 @MoonMoon1919