Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Windows ec2 instance example #1147

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

zackproser
Copy link
Contributor

@zackproser zackproser commented Jun 27, 2022

Description

Fixes #000.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@denis256
Copy link
Member

Looks like MODULE_CI_VERSION should also be updated to work on ubuntu 20.04

#!/bin/bash -eo pipefail
setup-minikube --k8s-version "$K8S_VERSION" --minikube-version "$MINIKUBE_VERSION"
ERROR: Runtime environment is not 16.04 (xenial) (detected Codename:	focal)

@zackproser zackproser force-pushed the feature/windows-instance-example branch from 2089ea5 to c04ec07 Compare June 28, 2022 14:53
@zackproser
Copy link
Contributor Author

Looks like MODULE_CI_VERSION should also be updated to work on ubuntu 20.04

#!/bin/bash -eo pipefail
setup-minikube --k8s-version "$K8S_VERSION" --minikube-version "$MINIKUBE_VERSION"
ERROR: Runtime environment is not 16.04 (xenial) (detected Codename:	focal)

Ah, thank you, Denis! I needed to rebase off master it seems 👍

@zackproser
Copy link
Contributor Author

Thanks for reviews! Going to merge this in now.

@zackproser zackproser merged commit f9a7663 into master Jun 30, 2022
@zackproser zackproser deleted the feature/windows-instance-example branch June 30, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants