Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1153 Quick start documentation update #1154

Merged
merged 1 commit into from
Jul 6, 2022
Merged

#1153 Quick start documentation update #1154

merged 1 commit into from
Jul 6, 2022
+2 −1

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Jul 4, 2022 •
edited

Description

Included changes:

  • updated minimal go version
  • added reference to execution go mod tidy

Fixes #1153.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated quick-start documentation

Migration Guide

yorinasub17
yorinasub17 approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit 044fd84 into master Jul 6, 2022
@denis256 denis256 deleted the bug/docs-fixes-1153 branch July 6, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorinasub17 yorinasub17 yorinasub17 approved these changes

@zackproser zackproser Awaiting requested review from zackproser

@rhoboat rhoboat Awaiting requested review from rhoboat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting started instructions do not work
2 participants
@denis256 @yorinasub17