Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publicly expose terraform.ParsePlanJSON function #1309

Merged
merged 1 commit into from Jul 10, 2023
Merged

publicly expose terraform.ParsePlanJSON function #1309

merged 1 commit into from Jul 10, 2023

Conversation

mdb
Copy link
Contributor

@mdb mdb commented Jun 15, 2023 •
edited

Description

This seeks to address #1308 by publicly exposing the terraform.ParsePlanJSON function, in effect better enabling the use of terratest for programmatically analyzing and validating a Terraform plan produced by an upstream, non-terratest process.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added public ParsePlanJSON function to terraform module.

@mdb mdb marked this pull request as ready for review June 15, 2023 17:56
@mdb
publicly expose terraform.ParsePlanJSON function
7f28553 
This seeks to fix gruntwork-io#1308 by publicly exposing the
`terraform.ParsePlanJSON` function, in effect better enabling the use of
`terratest` for programmatically analyzing and validating a Terraform
plan produced by an upstream, non-`terratest` process.

Signed-off-by: Mike Ball <mikedball@gmail.com>
@mdb
Copy link
Contributor Author

mdb commented Jun 26, 2023

@denis256 👋 Am I wrong to think the failures seen at https://github.com/gruntwork-io/terratest/pull/1309/checks?check_run_id=14537058165 are unrelated to the changes in this PR?

denis256
denis256 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@denis256 denis256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed tests are already fixed in master branch

@denis256 denis256 merged commit c6a3be9 into gruntwork-io:master Jul 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

@zackproser zackproser Awaiting requested review from zackproser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdb @denis256