Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terraform validation issues #931

Merged
merged 6 commits into from
Jun 17, 2021
Merged

Fix terraform validation issues #931

merged 6 commits into from
Jun 17, 2021

Conversation

zackproser
Copy link
Contributor

@zackproser zackproser commented Jun 16, 2021 •
edited

Fixes for the minor issues preventing a few modules from passing terraform validate as uncovered by the new TestValidateAllTerraformModulesOnTerratest test.

As can be seen in this test run, all TestValidateAllTerraformModulesOnTerratest sub tests are now passing.

yorinasub17
yorinasub17 reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one more consistency fix to suggest. Once that is addressed, and the build is passing, this is good to go!

test/terraform_aws_s3_example_test.go Outdated Show resolved Hide resolved
yorinasub17
yorinasub17 previously approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the build passes!

@zackproser
Copy link
Contributor Author

LGTM, assuming the build passes!

Thanks both for the reviews!

yorinasub17
yorinasub17 previously approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, assuming build passes.

rhoboat
rhoboat previously approved these changes Jun 16, 2021
View reviewed changes
@zackproser zackproser dismissed stale reviews from rhoboat and yorinasub17 via 9fa9950 June 16, 2021 23:30
@zackproser zackproser merged commit dff8b51 into master Jun 17, 2021
@zackproser zackproser deleted the fix-terraform-validation-issues branch June 17, 2021 12:19
This was referenced Jun 17, 2021
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

@yorinasub17 yorinasub17 yorinasub17 left review comments

@rhoboat rhoboat rhoboat left review comments

@bwhaley bwhaley Awaiting requested review from bwhaley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zackproser @yorinasub17 @brikis98 @rhoboat