-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBSAN shows a memory-access error #2
Comments
potentially fixed in edd6aaa. Will close issue once confirmed from CRAN. |
This is not closed yet as it brings up a new error with Address Sanitizer. I have potentially found the bug and fixed it in c9683db. As this new issue stems from a fix in this current issue, I will not close this until I get confirmation from CRAN. |
Looks like an issue with global versus local variable call? Thanks, On Jul 27, 2014, at 7:37 AM, Zhian N. Kamvar notifications@github.com wrote:
Niklaus J. Grünwald |
No. I believe the issue stems from memory not being freed unless a condition is met. Instead of allocating that memory outside of the condition, I am now allocating it inside. I will see if @JonahBrooks can help me make sure that this fixes the issue with ASan |
Forgot to include output of ASan:
|
A very simple error pointed out by @JonahBrooks: 5304db8 might fix the issues. This was not allocating enough memory for the array. We are attempting to run Asan on the development version of R to see if it will behave. |
After submission of poppr version 1.1.0 to CRAN, a notification was sent from Dr. Ripley notifying me of an error in UBSAN while running tests:
This error stems from illegal memory allocation. I will sanitize the code and post a patch.
The text was updated successfully, but these errors were encountered: