[DO NOT MERGE] add class SubprocessTestRunner #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for the PRs @douglasshimada, I'm gonna review them as soon as I can |
|
@douglasshimada make a PR for master |
|
tests? 😃 |
|
@lamenezes made some tests, please take a look |
| assert base_test.code_path != code_path | ||
|
|
||
|
|
||
| def test_subprocess(): |
There was a problem hiding this comment.
cada função representa um "caso de teste", portanto devemos criar testes que testam apenas uma coisa. na minha opinião dá para dividir este teste em 3.
lamenezes
changed the title
lamenezes
reviewed
Sep 17, 2016
|
|
||
|
|
||
| @pytest.fixture | ||
| def not_a_good_cmd(): |
lamenezes
reviewed
Sep 17, 2016
| """ | ||
| test_runner.py tests | ||
| Tested on Ubuntu 16.04 | ||
| """ |
There was a problem hiding this comment.
não precisa desses comentários
|
👍 ajeitando os pequenos comentários que fiz |
|
feito |
|
Thx, @douglasshimada! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request depends on #16 do not merge it. Otherwise we will have a bad time with git fixing the commits.