Refactor timer #29
Merged
Refactor timer #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamenezes
force-pushed
the
refactor-timer
branch
4 times, most recently
from
e83db6f
to
0886eae
Compare
lamenezes
force-pushed
the
refactor-timer
branch
from
0886eae
to
9be1852
Compare
lamenezes
force-pushed
the
refactor-timer
branch
from
9b28081
to
da51ddd
Compare
|
Mergeia aeeee \o/ |
|
@douglasshimada vc pode fazer merge sem problemas 😃 vou fazer agora pra usar hj msm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DojoTimerclass was responsible for many things like notifications and next round switch. Following the Single Responsability Principle [1] this refactor was made.This PR implements:
[1] https://en.wikipedia.org/wiki/Single_responsibility_principle