Maintenance #1
Closed
Maintenance #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I just found this by pure accident since it was linked with a teeny tiny "#1" on a commit I looked up in my own Sounds like you found and fixed a couple of bugs though, so - maybe you want to do this the right way around? :) |
* adds a setting for sd cancel command, #4368 not binding to settingsViewModel as expected, needs adjustment to API? * add settings API bits for binding issue * instantiate setting on init.
Otherwise we'll run into an error comparing with Flask's timezone aware headers. Fixes #4410
* Added FileMove- and FolderMove-Event * fixing the code formatting rules * 📝 Set version number Co-authored-by: Gina Häußge <gina@octoprint.org>
* Initial work for temperature markings * Made markings label always stay on graph * Made the markings persist after reload * Added myself to authors * Fixed prettier issues * Made markings types lower case and added Done marking * Code cleanup * Made markings expire after a while * Code cleanup * Some CSS changes & make it optional Co-authored-by: Gina Häußge <gina@octoprint.org>
* settings: reimplement storage chainmap This implementation is mostly compatible with the previous one, but in my opinion is much easier to read and much easier to reason about. The areas of incompatiblity are, in my opinion, bugs that have been fixed. * 💚 Fix a failing test Slight behaviour change means there's no emtpy dict left in the top layer but the whole key is gone. * 🎨 Let pre-commit do its thing after merge Co-authored-by: Gina Häußge <gina@octoprint.org>
Also let pr-validation create reviews instead of just comments.
Something's up with the cypress update and I can't reproduce it locally. Need to find a way to repro first, then fix, then reenable.
* No longer assume SD card is always available on Repetier
Drop sdAlwaysAvailable handling and react on Repetier
firmware messages related to SD cards. Octoprint
already handles some of these messages, so only
add missing pieces.
While at it also handle M22 release message for prusa firmware
("SD card released").
* 🚸 Move "sdAlwaysPresent" option in settings
With it no longer being set during auto detection or
Repetier specific, it makes sense to move it out
of the former location and into an advanced settings
area.
Co-authored-by: Gina Häußge <gina@octoprint.org>
* Add aria labels and roles for accessibility * Add aria-labels for bundled plugins Co-authored-by: Gina Häußge <gina@octoprint.org>
* Fire action hooks on ALL actions, not just unhandled ones * Add my name to the list Co-authored-by: Gina Häußge <gina@octoprint.org>
The redirect parameter to the login dialog now gets restricted to local URLs (as detected by unset scheme & netloc) that match a short list of allowed endpoints routes.
…4588) * Notify user if file or folder removal fails * Improve error messages for failed file or folder removal * Notify user if file is too large to upload * Improve notification for failed file and folder uploads
Lowercasing entire path causes wrong dir to be used in some cases like .octoprint/virtualsd instead of .octoprint/virtualSd.
Flask 2.2 requires werkzeug 2.2 which we can't upgrade to due to flask-login, and the current version pins might be causing issues in the field. TODO for 1.9.0: upgrade werkzeug & flask if possible with flask-login.
The cookie are port specific, so they need to be determine from the port from the base URL.
Uses native grep if available, otherwise falls back to a python implementation. Migrated from FileCheck plugin.
* Restore doesn't restore plugins versions. It isn't obvious that restore doesn't restore plugin version. * Update docs/bundledplugins/backup.rst Co-authored-by: Charlie Powell <31997505+cp2004@users.noreply.github.com>
Should reduce likelihood of brute force attacks on unsecure networks if users decide to deploy/make OctoPrint accessible there against all advice to the contrary.
- Use "M20 L T" (if CAPABILITY_EXTENDED_M20 is available) which gives us long file names but also file timestamps. - Wire up that timestamp into "date" field which gives us "Uploaded: ... ago" for files on SD card. Sorting by upload date also works. - Implementing this also fixes parsing of response to (for example manually sent) "M20 T" command. Octoprint assumed that third entry in response is always long file name while with M20 T it is timestamp. - Add conversion routines between M20 T timestamp and unix timestamp. Wire up that conversion in virtual printer. See also https://reprap.org/wiki/G-code#M20:_List_SD_card
Long filenames like 'more than one space.gcode' were shown in the UI as 'more than one space.gcode'
Admins may still change existing user account passwords without having to enter the current one, however the regular user oriented password change dialog has been adjusted to require entry of the current password. The API has been locked down accordingly and the password change endpoint has seen a small change due to that, please refer to the updated documentation.
Announcements will now no longer trigger a popup (unless from a priority 1 channel like Important) but instead cause an unread counter to be rendered on the notification icon (1-9 and infinity symbol for more). The announcement reader has been extended by a default "Unread" tab that shows all unread news items, and a Mark All Read button has been added to quickly get rid of the unread counter altogether. Should improve UX by reducing notification spam significantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your interest into contributing to OctoPrint, it's
highly appreciated!
Please make sure you have read the "guidelines for contributing" as
linked just above this form, there's a section on Pull Requests in there
as well that contains important information.
As a summary, please make sure you have ticked all points on this
checklist:
to a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
a bug fix for an issue present in the current stable version (no PRs
against master or anything else)
(no PRs from your version of master, maintenance or devel please),
e.g. dev/my_new_feature
no dead code, ideally only one commit - rebase your PR if necessary!
.less source files, not the .css files (those are generated with
lessc)
have added unit tests
nothing broke
Feel free to delete all this help text, then describe
your PR further. You may use the template provided below to do that.
The more details the better!
What does this PR do and why is it necessary?
The Terminal tab in OctoPrint erroneously filters valid GCODE. This fixes that.
Examples of code no currently accepted include:
+ G38.2 ...
+ M117testing [no space]
+ G1X10 [no space]
How was it tested? How can it be tested by the reviewer?
By manually typing (complete versions of) the above gcode commands into the terminal and pressing enter, while observing the message received by the printer's gcode interpreter.
Any background context you want to provide?
I'm working on Redeem, as of recent. We're aiming to make it properly GCODE compliant (RS274/NGC v3 for now), so as to eventually work with a large range of CNC machines, not just 3D Printers. OctoPrint is the terminal of choice, since I am currently developing on a 3DP. Then I found out I could even send GNN.nn commands. Hence this PR.
What are the relevant tickets if any?
None
Screenshots (if appropriate)
NA
Further notes
Oh ... I think I've said more than enough. hehe Catch you on Patreon some day.