Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup editing issues #100

Closed
SpotlightKid opened this issue Oct 31, 2017 · 3 comments
Closed

Markup editing issues #100

SpotlightKid opened this issue Oct 31, 2017 · 3 comments

Comments

@SpotlightKid
Copy link

General information

  • Device: Acer B3-A30
  • Android Version: Android 6.0
  • App version: v0.1.5

Steps to reproduce

  1. When entering an ordered list, after entering return after the second item line, no new item is generated on the next line.
  2. The toolbar button to insert a link does not use the current text selection as the link text.
  3. The H1 H2 and H3 buttons should enter the hash sign at the start of the line not at the current cursor position.
  4. The button for the horizontal line always inserts two lines of ----.

Expected result

  1. If the current line is an (un-)ordered list item and return is pressed, an appropriate item marker should be inserted at the beginning of the next line (after the proper indentation).
  2. When something is selected and the link button is clicked, the 'Name' field in the dialog that pops should be pre-filled with the selection text. Nice to have: If nothing is selected but the cursor is currently positioned in a link, the link markup should be parsed and the current link title filled in as well.
  3. The hash signs are inserted at the start of the line or the current selection.
  4. Only one new line with '----' is inserted.
@gsantner
Copy link
Owner

@jamiet-dev @sjmduncan
Could you/Do you want to take on this? Thanks 😄

@sjmduncan
Copy link
Contributor

I'll take this!

@gsantner
Copy link
Owner

gsantner commented Nov 6, 2017

thanks you very much! Please do fresh fork/clone from master branch, there was a big change some hours ago

subkanthi pushed a commit to subkanthi/markor that referenced this issue May 5, 2018
* Fix the insertion placement of characters from the shortcut bar & auto-populate the next line for ordered lists.
* Add an empty line before horizontal rule.
* Fix indexing for start-of-line insertions
* Remove old TODO comments that are done or obsolete.
* Auto-populate blockquote line prefixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants