Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1174 disallow screenshots #1514

Merged
merged 11 commits into from Dec 11, 2021
Merged

#1174 disallow screenshots #1514

merged 11 commits into from Dec 11, 2021

Conversation

simonesummo
Copy link
Contributor

Add FLAG_SECURE to activities to avoid screenshots.

@simonesummo simonesummo marked this pull request as draft November 30, 2021 08:23
@gsantner
Copy link
Owner

gsantner commented Dec 1, 2021

@Zoo-M0
I made a change and now all activites inherit from MarkorBaseActivity.
So you can now make the change there instead.
Note: It should be a additional settings option (preferences xml file), not "just add the flag"

@simonesummo
Copy link
Contributor Author

@gsantner perfect, I will move it to the new activity, and work on the preferences flag.

@simonesummo simonesummo marked this pull request as ready for review December 10, 2021 08:31
@simonesummo simonesummo changed the title Draft: #1174 disallow screenshots #1174 disallow screenshots Dec 10, 2021
@gsantner gsantner linked an issue Dec 11, 2021 that may be closed by this pull request
Privacy feature: Disallow screenshots (Secure flag) #1174
Closed
@gsantner gsantner added this to the 2.9 milestone Dec 11, 2021
gsantner
gsantner approved these changes Dec 11, 2021
View reviewed changes
Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked it a bit, merging now

thanks for your help 😄

as first-time-contribution - happy to hear more! 🎉

@gsantner gsantner merged commit c6af143 into gsantner:master Dec 11, 2021
@simonesummo simonesummo deleted the feature/#1174-disallow-screenshots branch December 13, 2021 08:27
@gsantner gsantner mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsantner gsantner gsantner approved these changes

Assignees

@gsantner gsantner

@simonesummo simonesummo

Labels
feature
Projects
None yet
Milestone
Markor v2.9.0
Development

Successfully merging this pull request may close these issues.

Privacy feature: Disallow screenshots (Secure flag)
2 participants
@simonesummo @gsantner