Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Show memes in system gallery #55

Closed
gsantner opened this issue Oct 3, 2017 · 7 comments
Closed

Toggle Show memes in system gallery #55

gsantner opened this issue Oct 3, 2017 · 7 comments

Comments

@gsantner
Copy link
Owner

gsantner commented Oct 3, 2017

Resolving this should toggle the visiblity of memes in the android system galleries (MediaScanner). For this you have to add (on creation), delete (on deletion) the meme from the system media database.

Additionally there should be an toggle provided in the Settings (SettingsActivity, preferences.xml) that in general toggles (enables/disables) this. Enabling means the deletion of %SAVEPATH%/memes/.nomedia and the addition of all current and future files in there. Deletion means creation of nomedia file and the removal of all items from the system media database.

Attention: This is ONLY about the media database. You must not delete any pictures here.

@gsantner
Copy link
Owner Author

gsantner commented Oct 3, 2017

If you need more information ask. This issue is an idea, and about people to start contributing to the project. It has not much information because I pasted many ideas/issues and just let them out at the same time :). If you are interested in working on this, and have questions I can give you more details on this.

Register on https://hacktoberfest.digitalocean.com/, send a PR to fix this and get your t-shirt for free (4 accepted PRs to same or different GitHub repositories needed) :). You have to mention the issue number in the commit/PR (e.g. fix #20 / about #8) Find more hacktober issues from my projects: https://github.com/search?&q=label%3Ahacktoberfest+user%3Agsantner

@jeffsieu
Copy link
Contributor

jeffsieu commented Oct 5, 2017

Hi, I am interesting in working on this issue.

I would like to clarify: Do you mean a toggle in settings is required, and this toggle toggles the visibility of the created memes in the system gallery, while showing them as normal within the application?

@gsantner
Copy link
Owner Author

gsantner commented Oct 5, 2017

Yes, the visibility of images inside MemeTastic is not affected in any means by this. This should really only control the visibility on normal android gallery apps

@jeffsieu
Copy link
Contributor

jeffsieu commented Oct 5, 2017

Okay, thanks. I'll work on it.

@jeffsieu
Copy link
Contributor

jeffsieu commented Oct 5, 2017

Hi @gsantner, please take a look at the pull request I've made, thank you.

@gsantner
Copy link
Owner Author

gsantner commented Oct 5, 2017

the PR doesnt contain any calls to update/add/delete index entries there. Your way the gallery will do a rescan at an ranfom time.

@jeffsieu
Copy link
Contributor

jeffsieu commented Oct 5, 2017

I have created another pull request that rectifies this issue.

jeffsieu added a commit to jeffsieu/memetastic that referenced this issue Oct 6, 2017
jeffsieu added a commit to jeffsieu/memetastic that referenced this issue Oct 6, 2017
gsantner pushed a commit that referenced this issue Oct 6, 2017
Add setting to show/hide pictures in device gallery, fixes #55
gsantner pushed a commit that referenced this issue Oct 24, 2017
Add setting to show/hide pictures in device gallery, fixes #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants