fix: Fix result error type for bitfield-rle update to 0.2.1 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may make sense to pin the fix version of bitfield-rle (to 0.2.1 for example), because it is not 1.0, updates such as 0.2 -> 0.2.1 may contain breaking changes such as this one when abiding by semantic versioning. |
causing issues in ggrs
|
Updated to pin version of bitfield-rle to prevent future upgrade failures such as: #72 |
|
Thanks for tracking this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitfield-rle just published version 0.2.1 which removes dependency on failure crate, which was failing advisories for being unmaintained.
GGRS uses bitfield-rle
0.2(fix version not restricted), when crates depending on ggrs update bitfield-rle in lock file, there is a related compiler error due to bitfield-rle error type changing.This should fix those issues and allow dependent crates on ggrs to upgrade bitfield-rle successfully.