Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 7: Incompatible with IntelliJ IDEA 12 #8

Merged
merged 6 commits into from
Jan 5, 2013
Merged

Fix for issue 7: Incompatible with IntelliJ IDEA 12 #8

merged 6 commits into from
Jan 5, 2013

Conversation

aheusingfeld
Copy link
Collaborator

I fixed the incombatible API calls for IDEA 12 and upgraded to IDEA 12.0.2 and Sonar 3.4

Issue: #7

* upgraded IntelliJ version to 12.0.2
* upgraded Sonar version to 3.4
* removed obsolete API methods
* made credentials optional in case they are not needed/ set

Issues: #7
* added checkbox to indicate whether proxy settings shall be used

Issues: #8
* extracted "getSonar()" method from all components to SonarUtils
* made all components use the same implementation of getSonar
* refactored getSonar method to check whether to use IDEA's proxy settings
* added checkbox to indicate whether proxy settings shall be used
@aheusingfeld
Copy link
Collaborator Author

Added commit aheusingfeld@cae1463 so that the Sonar plugin checks IntelliJ IDEA's proxy settings to connect to the Sonar instance.

gshakhn added a commit that referenced this pull request Jan 5, 2013
Fix for issue 7: Incompatible with IntelliJ IDEA 12
@gshakhn gshakhn merged commit 36f5734 into gshakhn:master Jan 5, 2013
@gshakhn
Copy link
Owner

gshakhn commented Jan 5, 2013

Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants