Fix memory cyles causing leaks

gshank · May 13, 2011 · 2aa7393 · 2aa7393
1 parent 0b69b55
commit 2aa7393
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/lib/HTML/FormHandler.pm b/lib/HTML/FormHandler.pm
@@ -678,21 +678,16 @@ form name.
 
 =cut
 
+# for consistency in api with field nodes
+sub form { shift }
+sub has_form { 1 }
+
 # Moose attributes
 has 'name' => (
     isa     => 'Str',
     is      => 'rw',
     default => sub { return 'form' . int( rand 1000 ) }
 );
-# for consistency in api with field nodes
-has 'form' => (
-    isa      => 'HTML::FormHandler',
-    is       => 'rw',
-    weak_ref => 1,
-    predicate => 'has_form',
-    lazy     => 1,
-    default  => sub { shift }
-);
 has 'parent' => ( is => 'rw' );
 has 'result' => (
     isa       => 'HTML::FormHandler::Result',

diff --git a/lib/HTML/FormHandler/Field.pm b/lib/HTML/FormHandler/Field.pm
@@ -646,7 +646,7 @@ errors with C<< $field->add_error >>.
 
 has 'name' => ( isa => 'Str', is => 'rw', required => 1 );
 has 'type' => ( isa => 'Str', is => 'rw', default => sub { ref shift } );
-has 'parent' => ( is  => 'rw',   predicate => 'has_parent' );
+has 'parent' => ( is  => 'rw',   predicate => 'has_parent', weak_ref => 1 );
 sub has_fields { }
 has 'input_without_param' => (
     is        => 'rw',