On Windows, fill the events[] array in reverse order. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps guarantee the events will be processed in round robin order even when one event is busier than the others. The event loop uses splay_search() to lookup the io_t by the selected event, splaying the tree. As a result, the busy event (usually TAP) will always be first in the events[] array, which usually results in its index being returned by the next call to WSAWaitForMultipleEvents(). By putting the most active event last in events[], other active events get a chance to run. Otherwise, we may starve events other than the TAP, which is usually at the head. This can cause missed PING replies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps guarantee the events will be processed in round robin order even when one event is busier than the others. The event loop uses splay_search() to lookup the io_t by the selected event, splaying the tree. As a result, the busy event (usually TAP) will always be first in the events[] array, which usually results in its index being returned by the next call to WSAWaitForMultipleEvents(). By putting the most active event last in events[], other active events get a chance to run.
Otherwise, we may starve events other than the TAP, which is usually at the head. This can cause
missed PING replies.