Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Windows, fill the events[] array in reverse order. #182

Closed
wants to merge 1 commit into from
Closed

On Windows, fill the events[] array in reverse order. #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/event.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,11 +403,16 @@ bool event_loop(void) {
}

WSAEVENT *events = xmalloc(event_count * sizeof(*events));
DWORD event_index = 0;
DWORD event_index = event_count;

/*
* Fill events[] in reverse order. This helps guarantee the
* events will be processed in round robin order even when one
* event is busier than the others. Otherwise we may starve
* events other than the TAP, which is usually at the head.
*/
for splay_each(io_t, io, &io_tree) {
events[event_index] = io->event;
event_index++;
events[--event_index] = io->event;
}

DWORD result = WSAWaitForMultipleEvents(event_count, events, FALSE, timeout_ms, FALSE);
Expand Down