Unwrap processing exception from REST Client when returning a Uni

Originally reported at: https://stackoverflow.com/q/78108545/2504224
gsmet · Mar 6, 2024 · 3e60238 · 3e60238
1 parent 22dcfe1
commit 3e60238
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/...ment/src/test/java/io/quarkus/rest/client/reactive/error/ResponseExceptionMapperTest.java b/...ment/src/test/java/io/quarkus/rest/client/reactive/error/ResponseExceptionMapperTest.java
@@ -19,6 +19,7 @@
 import org.junit.jupiter.api.extension.RegisterExtension;
 
 import io.quarkus.test.QuarkusUnitTest;
+import io.smallrye.mutiny.Uni;
 
 public class ResponseExceptionMapperTest {
     @RegisterExtension
@@ -34,8 +35,11 @@ public class ResponseExceptionMapperTest {
 
     @Test
     void shouldInvokeExceptionMapperOnce() {
-        assertThrows(RuntimeException.class, client::get);
+        assertThrows(TestException.class, client::get);
         assertThat(MyExceptionMapper.executionCount.get()).isEqualTo(1);
+
+        assertThrows(TestException.class, () -> client.uniGet().await().indefinitely());
+        assertThat(MyExceptionMapper.executionCount.get()).isEqualTo(2);
     }
 
     @Path("/error")
@@ -51,6 +55,9 @@ public Response returnError() {
     public interface Client {
         @GET
         String get();
+
+        @GET
+        Uni<String> uniGet();
     }
 
     @Provider
@@ -61,7 +68,14 @@ public static class MyExceptionMapper implements ResponseExceptionMapper<Excepti
         @Override
         public Exception toThrowable(Response response) {
             executionCount.incrementAndGet();
-            return new RuntimeException("My exception");
+            return new TestException("My exception");
+        }
+    }
+
+    public static class TestException extends RuntimeException {
+
+        public TestException(String message) {
+            super(message);
         }
     }
 

diff --git a/...tive/client/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/UniInvoker.java b/...tive/client/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/UniInvoker.java
@@ -1,8 +1,10 @@
 package org.jboss.resteasy.reactive.client.impl;
 
 import java.util.concurrent.CompletionStage;
+import java.util.function.Function;
 import java.util.function.Supplier;
 
+import jakarta.ws.rs.ProcessingException;
 import jakarta.ws.rs.client.Entity;
 import jakarta.ws.rs.core.GenericType;
 import jakarta.ws.rs.core.Response;
@@ -25,6 +27,14 @@ public <R> Uni<R> method(String name, Entity<?> entity, GenericType<R> responseT
             public CompletionStage<R> get() {
                 return invoker.method(name, entity, responseType);
             }
+        }).onFailure().transform(new Function<>() {
+            @Override
+            public Throwable apply(Throwable t) {
+                if ((t instanceof ProcessingException) && (t.getCause() != null)) {
+                    return t.getCause();
+                }
+                return t;
+            }
         });
     }