Django 1.4 compatibility since randrange is no longer available in contrib.sessions.backends.base

[adamn]

django/django@bde0ed9 on Django took randrange out of contrib.sessions.backends.base

[gtaylor]

Good find, but it looks like only the randrange import was removed. It appears to still be used throughout backends/dynamodb.py.

[adamn]

My bad - I was premature on that one. _get_new_session_key() should be removed entirely as well as the import of MAX_SESSION_KEY.

[adamn]

And therefore import os can be removed as well. Thoughts?

[gtaylor]

Yeah, that looks right. I may not have time to figure this out today, but if you're able to send a pull request, I can slap it in one of our Django 1.4 projects and check it over fast enough to get it merged.

[gtaylor]

Awesome, I'll try to get this one merged in tonight. Any idea if this does anything to our Django 1.3 compatibility? I'm not really concerned with 1.2 or anything earlier, and I'm borderline not concerned with 1.3, but figured I'd be a good sport.

[adamn]

1.3.1 has a similar setup so I don't foresee any problem on that front:

https://github.com/django/django/blob/1.3.1/django/contrib/sessions/backends/base.py

---

Adam Nelson - CTO
Join Yipit and be our Lead Interaction Designer @
http://yipit.com/jobs/http://yipit.com/about/jobs/

On Wed, Apr 25, 2012 at 4:56 PM, Greg Taylor <
reply@reply.github.com

wrote:

Awesome, I'll try to get this one merged in tonight. Any idea if this does
anything to our Django 1.3 compatibility? I'm not really concerned with 1.2
or anything earlier, and I'm borderline not concerned with 1.3, but figured
I'd be a good sport.

---

Reply to this email directly or view it on GitHub:

#2 (comment)

[gtaylor]

Released on PyPi as 0.4. Thanks!