Add subcategories to reports #8
Conversation
This is patch https://launchpadlibrarian.net/161449651/gtimelog-0.9.1__subcats_withdate__20140102.diff from https://bugs.launchpad.net/gtimelog/+bug/1185041, applied with git apply, for review purposes.
| @@ -51,6 +51,19 @@ class Settings(object): | |||
| start_in_tray = False | |||
|
|
|||
| report_style = 'plain' | |||
| """If True then timestamp of the event will be present in categorized report""" | |||
There was a problem hiding this comment.
Please use comment syntax here.
|
Unfortunately GitHub doesn't show whitespace errors I saw with This patch needs to be split into smaller bits, e.g. first split out the refactoring to pass the settings object to TimeLog/TimeWindow/Reports classes (but ditch the setter methods -- provide a mock class in the tests). There are some bits missing:
I'm still uneasy about having the subcategory separator configurable. |
|
Thank you very much for your time and comments! I agree with most of your points - formatting, PEP8,... What do you think about whole concept of subcategories as implemented by this patch? Do you think is the feature OK and after solving technical details/errors can it be merged into master? If so - I will seperate the patch to smaller bits. |
Replace 4 tab characters with spaces
I haven't made up my mind completely about the syntax yet. Ideally the parsing will be contained in a single function/method, and we can experiment easily. |
See https://bugs.launchpad.net/gtimelog/+bug/1185041