Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of merge with libadwaita package #10

Closed
jesusrp98 opened this issue Dec 29, 2021 · 4 comments
Closed

Possibility of merge with libadwaita package #10

jesusrp98 opened this issue Dec 29, 2021 · 4 comments

Comments

@jesusrp98
Copy link
Contributor

I was wondering why there are two 'adwaita' packages: one for the theming and colors and another for ui and widgets.

Inside the new libadwaita library offered by the GNOME project both style and widgets are inside one library, so it would make sense two merge this package into libadwaita.

I'd like this issue to serve as a point of discussion for all of us :)

@prateekmedia
Copy link
Member

Hmm, I think this originated from here gtk-flutter/libadwaita#12

@MalcolmMielle
Copy link
Collaborator

This package enables users to use the Adwaita theme without having to import/use Adwaita widgets. That way, if I build an app using a custom widget, the Adwatia theme will be automatically applied, but I don't need to pull the whole library of Adwaita widgets.

@jesusrp98
Copy link
Contributor Author

OK I see what you're saying there. I saw that Canonical is doing that for their theme.

Personally, I think it doesn't make too much sense, because if you plan to create new custom adwaita widgets in your app, there's a pretty good chance that you're also going to use any of the widgets offered by libadwaita.

This is just my personal opinion, not saying that this should be fixed or anything, just a thought :)

@MalcolmMielle
Copy link
Collaborator

If someone wants to simply adapt their existing app to have an Adwaita look without using the Adwaita widget, they can for now simply use the theme like any other Flutter theme. This way, the Adwaita ecosystem is more modulable and the theme can also be used on other platforms (in case libadwaita end-up being linux only).

I'd say we follow the Canonical way of doing it, simply because I see no upside for change :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants