Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

SurfaceExt is not exported #252

Closed
federicomenaquintero opened this issue Mar 14, 2019 · 5 comments
Closed

SurfaceExt is not exported #252

federicomenaquintero opened this issue Mar 14, 2019 · 5 comments

Comments

@federicomenaquintero
Copy link
Contributor

This seems like just an oversight, since lib.rs has

pub use surface::{
    MappedImageSurface,
    Surface,
};

Will submit a PR shortly.

@federicomenaquintero
Copy link
Contributor Author

Huh, I just noticed that it is exported, but from the prelude.

@sdroege
Copy link
Member

sdroege commented Mar 15, 2019

It should be exported from both though :) All types should be exported from lib.rs and all traits also from prelude

@federicomenaquintero
Copy link
Contributor Author

I always wondered what should be in a prelude. Traits? Anything else?

@GuillaumeGomez
Copy link
Member

Traits only normally.

@sdroege
Copy link
Member

sdroege commented Mar 17, 2019

Not only normally. Only traits ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants