Make winapi optional. #280
Conversation
|
@RazrFalcon Thanks |
|
@EPashkin It has cfgs already. Not sure what it doesn't like. I've tested it on a local machine first. Looks like |
|
I've enabled |
cairo-sys-rs/src/lib.rs
Outdated
| extern crate winapi as winapi_orig; | ||
|
|
||
| #[cfg(windows)] | ||
| #[cfg(all(windows, feature = "win32-surface"))] |
There was a problem hiding this comment.
IMHO also need to add "dox" here and to previous cfg
There was a problem hiding this comment.
No, I was wrong, "dox" in Cargo.toml not needed "winapi" as it will fail on nonwindows.
And here needed separate module for it
#[cfg(feature = "dox")]
pub mod winapi {
pub enum HDC__ {}
pub type HDC = *mut HDC__;
}
There was a problem hiding this comment.
Maybe with and and(.., not(all(windows, feature = "win32-surface")) but IMHO this unneeded as docs will be generated on unix anyway.
|
@RazrFalcon Thanks, 👍 |
|
👍 |
Currently, the
winapicrate is mandatory. But it's very big (100MB). This patch makes it optional by introducing thewin32-surfacefeature.