Add menu bar example #88

GuillaumeGomez · 2016-04-24T23:25:41Z

EPashkin · 2016-04-24T23:30:48Z

No check items and others?

GuillaumeGomez · 2016-04-24T23:32:03Z

I wanted to make this example as light as possible but maybe it's too light now haha.

gkoz · 2016-04-24T23:33:35Z

src/menu_bar.rs

+        let p = Dialog::new_with_buttons(Some("About"),
+                                         Some(&window),
+                                         gtk::DIALOG_MODAL,
+                                         &[("Ok", gtk::ResponseType::Ok as i32)]);


Huh. I guess we've got a problem: a breaking change, which doesn't actually break the build. This new enum wasn't supposed to be convertible via as i32 but it still is. Might have to make the __Nonexhaustive member non-empty to prevent this.
The proper conversion would be ResponseType::Ok.into().

Dialog still needed i32 not gtk::ResponseType?

It supports arbitrary response codes and until ResponseType accommodates that it needs i32. Additionally, gir doesn't have a facility to substitute ResponseType for i32 where we want it to :(

To be clear, right now ResponseType::Ok as i32 == 4 while for the type formerly known as ResponseType it's gtk_sys::GtkResponseType::Ok as i32 == -5 and that is what .into() will return.

May be it be error after rust-lang/rust#3868 ?

Also make __Nonexhaustive(()) will break as i32

Yes, we'll probably make __Nonexhaustive(()).

Then I make 3 PR's:
examples: change as i32 to .into() for all generated enums,
gir: change generation,
gtk: regen

Gtk changes in https://github.com/EPashkin/rust-gnome-gtk/tree/block_enum_to_i32

gkoz · 2016-04-25T11:25:45Z

src/menu_bar.rs

+    window.show_all();
+
+    about.connect_activate(move |_| {
+        let p = Dialog::new_with_buttons(Some("About"),


Aren't you supposed to use AboutDialog here?

GuillaumeGomez · 2016-04-25T15:11:00Z

@EPashkin: Happier? ;)

EPashkin · 2016-04-25T15:53:46Z

@GuillaumeGomez rebase please, currently has IconSize::Button as i32

EPashkin · 2016-04-25T15:55:53Z

Hm, now github as New changes since you last viewed

EPashkin · 2016-04-25T15:57:46Z

Looks great.
May be better hide "License" button in "About" as it empty?

EPashkin · 2016-04-25T15:58:52Z

Also closing by button not work in "About", seems it result of

Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

EPashkin · 2016-04-25T16:04:05Z

In gtktest all normal with About.

gkoz · 2016-04-25T16:27:49Z

src/menu_bar.rs

+        p.set_website_label(Some("gtk-rs"));
+        p.set_website(Some("http://gtk-rs.org"));
+        p.set_comments(Some("What a menu bar example!"));
+        p.set_copyright(Some("All rights reserved to us (of course!)"));


Come on, the license is MIT

Okay, I put it...

gkoz · 2016-04-25T16:28:39Z

In gtktest all normal with About.

GTK asks for a parent window and it's set in gtktest (set_transient_for).

GuillaumeGomez · 2016-04-25T22:14:07Z

I changed copyright (less fun now...) and added parent window.

EPashkin · 2016-04-26T03:24:01Z

About still has not working "License" and "Close" button, in "gtktest" license is hidden and close working.
And rebase please

gkoz · 2016-04-26T10:25:39Z

src/menu_bar.rs

+    menu.append(&about);
+    menu.append(&quit);
+    file.set_submenu(Some(&menu));
+    menu_bar.append(&file);


We should try to use Glade (UI metadata editor). No one is expected to build UIs programmatically these days.

Anyone can use Glade. I think it's a good thing to show how it works programatically. However, we could provide all examples in Glade version.

There's a chance we're unaware of some obstacles to using Glade, especially around menus and actions. The GTK learning materials push strongly toward using Glade, doing a lot of these manipulations manually seems unidiomatic. So we need to prioritize making sure the Glade way works.

GuillaumeGomez · 2016-04-28T13:11:27Z

So, do we merge this PR?

gkoz · 2016-04-28T13:13:45Z

I'd very much like it if the menu (or the whole UI) would be defined in XML.

GuillaumeGomez · 2016-04-28T13:15:01Z

And I said that I'd do it, but in a separated example.

GuillaumeGomez · 2016-04-28T13:15:38Z

Actually, we should do this for all examples.

gkoz · 2016-04-28T13:17:43Z

Frankly, teaching users to do this stuff manually is a disservice. This is not what they need to learn to be efficient at making GTK apps.

GuillaumeGomez · 2016-04-28T13:24:14Z

All the other examples have been written by hand. This one isn't an exception. The point of these examples is to show how do it, either they want to do it by using GLADE or not.

gkoz · 2016-04-28T13:44:15Z

I'm afraid this hasn't been how to do it for years now. We just sort of weren't paying attention. It's unfortunate that the existing examples don't match the modern ways but it's not an excuse for not learning new things and keeping rehashing the old stuff.

GuillaumeGomez · 2016-04-28T15:12:47Z

And so that's why I proposed to have both ways.

EPashkin · 2016-04-28T15:47:10Z

@GuillaumeGomez seems no changes to fixing my comment (not tested).

"About" still has not working "License" and "Close" button, in "gtktest" license is hidden and close working.
And rebase please

EPashkin · 2016-04-28T15:48:30Z

@gkoz direct way generating allow to show how to use library, so I prefer have only one Glade example and other same that this.

GuillaumeGomez · 2016-04-28T15:52:20Z

@gkoz direct way generating allow to show how to use library, so I prefer have only one Glade example and other same that this.

You're more extreme than me! ;) Providing an example in both GLADE and full "hand-made" source code seems a good compromise.

@GuillaumeGomez seems no changes to fixing my comment (not tested).

I wait for @gkoz to agree for this to be merged before modifying.

gkoz · 2016-04-28T15:57:18Z

Okay, let's have the manual example. You still need to make loading of the image work regardless of $CWD.

EPashkin · 2016-04-28T20:00:55Z

I changed my options on using glade: goal of examples is show how do some task and better that example concentrated to this task, so if you need do some complex preparation then better use any way to simplify it.
But my option about this example still unaffected as example for working with menu.

@gkoz Can we include image to code as resource at compile time and use it?

GuillaumeGomez · 2016-04-28T20:07:52Z

@gkoz Can we include image to code as resource at compile time and use it?

It's possible, I did it in C++. However I have no clue how to do so in Rust...

gkoz · 2016-04-28T20:19:56Z

goal of examples is show how do some task and better that example concentrated to this task

Normally programmatic UI initialization isn't something one should want to accomplish and examples suggesting that approach distract from learning the idiomatic way.

Can we include image to code as resource at compile time and use it?

Presumably using glib-compile-resources and then doing something like this should work. We might consider making a convenience function to achieve that with less boilerplate.

GuillaumeGomez · 2016-04-28T20:35:20Z

Updated. Do you still have the issues @EPashkin?

EPashkin · 2016-04-28T21:06:05Z

Thanks, @GuillaumeGomez.
All good except picture, but it can be done later, as it better changed to many examples.

gkoz · 2016-04-28T22:23:33Z

src/menu_bar.rs

+    AboutDialog, BoxExt, CheckMenuItem, ContainerExt, DialogExt, IconSize, Image, Inhibit, Label,
+    Menu, MenuBar, MenuItem, MenuItemExt, MenuShellExt, WidgetExt, WidgetSignals,
+    Window, WindowExt, WindowPosition, WindowType
+};


We don't import traits one by one.

I'll replace by gtk::prelude::* after what we experienced recently.

GuillaumeGomez · 2016-04-28T23:57:16Z

Updated.

gkoz · 2016-04-29T00:19:09Z

Thanks!

gkoz reviewed Apr 24, 2016
View reviewed changes

This was referenced Apr 25, 2016

Fix converting generated enums to i32 #89

Merged

Make cast generated enums to i32 non-scalar gtk-rs/gir#251

Merged

gkoz reviewed Apr 25, 2016
View reviewed changes

EPashkin mentioned this pull request Apr 25, 2016

Deignoring gtk-rs/gtk#319

Merged

gkoz reviewed Apr 25, 2016
View reviewed changes

gkoz reviewed Apr 26, 2016
View reviewed changes

Add menu bar example

bd2fe23

gkoz reviewed Apr 28, 2016
View reviewed changes

gkoz merged commit cfc782c into gtk-rs:pending Apr 29, 2016

GuillaumeGomez deleted the pending branch April 29, 2016 08:39

Add menu bar example #88

Add menu bar example #88

Conversation

GuillaumeGomez commented Apr 24, 2016

EPashkin commented Apr 24, 2016

GuillaumeGomez commented Apr 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuillaumeGomez commented Apr 25, 2016

EPashkin commented Apr 25, 2016 • edited

EPashkin commented Apr 25, 2016

EPashkin commented Apr 25, 2016

EPashkin commented Apr 25, 2016 • edited

EPashkin commented Apr 25, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gkoz commented Apr 25, 2016 • edited

GuillaumeGomez commented Apr 25, 2016

EPashkin commented Apr 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuillaumeGomez commented Apr 28, 2016

gkoz commented Apr 28, 2016

GuillaumeGomez commented Apr 28, 2016

GuillaumeGomez commented Apr 28, 2016

gkoz commented Apr 28, 2016

GuillaumeGomez commented Apr 28, 2016

gkoz commented Apr 28, 2016 • edited

GuillaumeGomez commented Apr 28, 2016

EPashkin commented Apr 28, 2016

EPashkin commented Apr 28, 2016

GuillaumeGomez commented Apr 28, 2016 • edited

gkoz commented Apr 28, 2016

EPashkin commented Apr 28, 2016

GuillaumeGomez commented Apr 28, 2016

gkoz commented Apr 28, 2016

GuillaumeGomez commented Apr 28, 2016

EPashkin commented Apr 28, 2016

gkoz Apr 28, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuillaumeGomez commented Apr 28, 2016

gkoz commented Apr 29, 2016

EPashkin commented Apr 25, 2016 •

edited

EPashkin commented Apr 25, 2016 •

edited

EPashkin commented Apr 25, 2016 •

edited

gkoz commented Apr 25, 2016 •

edited

gkoz commented Apr 28, 2016 •

edited

GuillaumeGomez commented Apr 28, 2016 •

edited

gkoz Apr 28, 2016 •

edited