-
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
It would be nice to have some safe solution to ensure that the event record we receive in the signal handler is of the correct type (probably implement |
I’m sorry, I don’t understand – is there some problem with this PR? Should some members remain unpublished? |
These belong in |
Okay, but in the meantime, is there any reason why some events (e. g. |
Can't answer for why some of the stuff has been done the way it is but it's way unfinished for sure. |
Not really… I’ll add a commit to unpublish them (including those that were public before). |
What, the event structs are missing |
@@ -72,6 +72,8 @@ pub trait Event: Sized { | |||
} | |||
} | |||
|
|||
// TODO unfisished, see some discussion in #21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this #25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done (squash + rebase), also fixed the typo in “unfi_s_ished”
Done. |
Here I am ! @lucaswerkmeister: Nice job and thanks for your work ! |
Cool, thanks for merging! |
No description provided.