New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing get_device methods #231

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Jul 17, 2018

Fixes #230.

cc @sdroege @EPashkin

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 17, 2018

Member

@GuillaumeGomez Code look good, Thanks. 👍

@sdroege There again problem with futures on nightly, seems its updated.

Member

EPashkin commented Jul 17, 2018

@GuillaumeGomez Code look good, Thanks. 👍

@sdroege There again problem with futures on nightly, seems its updated.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 17, 2018

Member

Looks good

Member

sdroege commented Jul 17, 2018

Looks good

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 17, 2018

Member

Then I merge but weird failure...

Member

GuillaumeGomez commented Jul 17, 2018

Then I merge but weird failure...

@GuillaumeGomez GuillaumeGomez merged commit 69763b8 into gtk-rs:master Jul 17, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:add-missing-get-device branch Jul 17, 2018

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 18, 2018

Member

Then I merge but weird failure...

I can reproduce it here but it seems to be first of all a bug in nightly. It complains to add #![feature(proc_macro)] but that already is there.

Member

sdroege commented Jul 18, 2018

Then I merge but weird failure...

I can reproduce it here but it seems to be first of all a bug in nightly. It complains to add #![feature(proc_macro)] but that already is there.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege
Member

sdroege commented Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment