This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Restore and deprecate wrong named functions #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Yes that's what I meant, but only for the bugfix release. For master it's ok to not have it :) |
EPashkin
force-pushed
the
restore_and_deprecate
branch
from
d948f48
to
84c9ace
Compare
|
For master not adding is ok only if we plan to remove deprecated in next major, |
That's the plan. It's simply wrong and trivial to fix for people when updating. Let's not add it back in master, but it would probably be nice to have the wrong name deprecated in the bugfix release and the correct name available. |
|
Ok, lets close it then |
|
Instead of closing, rebase it on the 0.8 branch :) |
|
Let's just change things in master, yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @sdroege