Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GIR files (2024-01-18) #181

Merged
merged 1 commit into from Jan 18, 2024
Merged

Update GIR files (2024-01-18) #181

merged 1 commit into from Jan 18, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 8, 2023 •
edited

This PR was auto-generated on 2024-01-18. Please review and manually edit before merging.

sdroege
sdroege reviewed Oct 9, 2023
View reviewed changes
GLib-2.0.gir Outdated
@@ -17356,6 +17380,16 @@ the pointer passed to it should not be `volatile`.</doc>
</parameter>
</parameters>
</function>
<function name="init_enter_pointer" c:identifier="g_once_init_enter_pointer">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update of gobject-introspection

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is it expected that the GNOME SDK is already following next GLib? Asking because graphene looks like it was downgraded to a release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is it expected that the GNOME SDK is already following next GLib

Yes, it tracks glib from main

Asking because graphene looks like it was downgraded to a release.

We switched from tracking master to tracking tags for graphene, so it went from 1.10.6-42-g0cfa05ff62f244e4d5e7ac35a1979a23f25c5151 to 1.10.8-0-g4e2578450809c2099400cf85caf18eafcd7100aa

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so this is all expected and the only thing we need is to get gobject-introspection updated for the GLib introspection data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gitlab.gnome.org/GNOME/gobject-introspection/-/merge_requests/423

sdroege
sdroege reviewed Oct 9, 2023
View reviewed changes
Graphene-1.0.gir Outdated
@@ -3200,23 +3194,6 @@ or graphene_point_init_from_point(), e.g.:
</parameter>
</parameters>
</method>
<method name="distance_squared" c:identifier="graphene_point_distance_squared" version="1.12">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just added in ebassi/graphene@362c9d8 . Did the gir file get downgraded in the GNOME SDK?

sdroege
sdroege reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks OK

@github-actions github-actions bot changed the title Update GIR files (2023-10-08) Update GIR files (2023-10-13) Oct 13, 2023
bilelmoussaoui
bilelmoussaoui reviewed Oct 13, 2023
View reviewed changes
Gdk-4.0.gir Outdated Show resolved Hide resolved
Gdk-4.0.gir Outdated Show resolved Hide resolved
Gdk-4.0.gir Outdated Show resolved Hide resolved
@github-actions github-actions bot changed the title Update GIR files (2023-10-13) Update GIR files (2023-10-15) Oct 15, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-10-15) Update GIR files (2023-10-22) Oct 22, 2023
bilelmoussaoui
bilelmoussaoui reviewed Oct 22, 2023
View reviewed changes
Gdk-4.0.gir Outdated Show resolved Hide resolved
@github-actions github-actions bot changed the title Update GIR files (2023-10-22) Update GIR files (2023-10-29) Oct 29, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-10-29) Update GIR files (2023-11-05) Nov 5, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-11-05) Update GIR files (2023-11-12) Nov 12, 2023
sdroege
sdroege reviewed Nov 12, 2023
View reviewed changes
Gio-2.0.gir Outdated
@@ -6930,6 +6943,19 @@ calling g_printerr() in the invoking process.</doc>
</parameter>
</parameters>
</method>
<method name="printerr_literal" c:identifier="g_application_command_line_printerr_literal">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess for all the GLib things we just wait until GObject-Introspection is properly merged in there and no separate syncing of introspection data is needed.

@alatiera The GNOME SDK is going to build GLib like that then, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check up on the plan of merging libgi into glib, but otherwise we are gonna be building the girs from glib. Already done, just waiting review https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/2473

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so either way just needs a bit of waiting here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting should be over

@github-actions github-actions bot changed the title Update GIR files (2023-11-12) Update GIR files (2023-11-19) Nov 19, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-11-19) Update GIR files (2023-11-26) Nov 26, 2023
@sdroege sdroege mentioned this pull request Nov 27, 2023
Closed
@github-actions github-actions bot changed the title Update GIR files (2023-11-26) Update GIR files (2023-12-03) Dec 3, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-12-03) Update GIR files (2023-12-10) Dec 10, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-12-10) Update GIR files (2023-12-17) Dec 17, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-12-17) Update GIR files (2023-12-24) Dec 24, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-12-24) Update GIR files (2023-12-31) Dec 31, 2023
@github-actions github-actions bot changed the title Update GIR files (2023-12-31) Update GIR files (2024-01-03) Jan 3, 2024
@github-actions github-actions bot changed the title Update GIR files (2024-01-03) Update GIR files (2024-01-04) Jan 4, 2024
@sdroege sdroege mentioned this pull request Jan 5, 2024
Closed
@github-actions github-actions bot changed the title Update GIR files (2024-01-04) Update GIR files (2024-01-06) Jan 6, 2024
@github-actions github-actions bot changed the title Update GIR files (2024-01-06) Update GIR files (2024-01-07) Jan 7, 2024
@github-actions github-actions bot changed the title Update GIR files (2024-01-07) Update GIR files (2024-01-10) Jan 10, 2024
@github-actions github-actions bot changed the title Update GIR files (2024-01-10) Update GIR files (2024-01-14) Jan 14, 2024
@github-actions github-actions bot changed the title Update GIR files (2024-01-14) Update GIR files (2024-01-15) Jan 15, 2024
@github-actions github-actions bot changed the title Update GIR files (2024-01-15) Update GIR files (2024-01-18) Jan 18, 2024
@bilelmoussaoui
Copy link
Member

Let us land this and follow up and issues once I open a regeneration PR in both gtk-rs-core/gtk4-rs

@bilelmoussaoui bilelmoussaoui merged commit 21b29d0 into master Jan 18, 2024
@bilelmoussaoui bilelmoussaoui deleted the create-pull-request/patch branch January 18, 2024 14:23
@andy128k andy128k mentioned this pull request Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege left review comments

@bilelmoussaoui bilelmoussaoui bilelmoussaoui left review comments

@alatiera alatiera alatiera left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bilelmoussaoui @sdroege @alatiera