Merge pull request #995 from sdroege/remove-setvalueoptional-trait-bound

This is not needed any longer
gtk-rs · Nov 19, 2020 · 062b3d6 · 062b3d6
2 parents 1ae9689 + 80b31bd
commit 062b3d6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/analysis/properties.rs b/src/analysis/properties.rs
@@ -214,7 +214,6 @@ fn analyze_property(
             imports.add("glib::Value");
             if set_bound.is_some() {
                 imports.add("glib::object::IsA");
-                imports.add("glib::value::SetValueOptional");
                 if !*nullable {
                     //TODO: support nonnulable setter if found any
                     warn!(

diff --git a/src/codegen/properties.rs b/src/codegen/properties.rs
@@ -76,10 +76,7 @@ fn declaration(env: &Env, prop: &Property) -> String {
         bound = String::new();
         String::new()
     } else if let Some(ref set_bound) = prop.set_bound {
-        bound = format!(
-            "<{}: IsA<{}> + SetValueOptional>",
-            set_bound.alias, set_bound.type_str
-        );
+        bound = format!("<{}: IsA<{}>>", set_bound.alias, set_bound.type_str);
         format!(", {}: Option<&{}>", prop.var_name, set_bound.alias)
     } else {
         bound = String::new();