Fix some clippy warnings about redundant ifs

gtk-rs · Dec 17, 2019 · 415d9ac · 415d9ac
1 parent f86f610
commit 415d9ac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/analysis/functions.rs b/src/analysis/functions.rs
@@ -721,10 +721,10 @@ fn analyze_function(
     }
 
     if !commented {
-        if !destroys.is_empty() || !callbacks.is_empty() {
-            if callbacks.iter().any(|c| !c.scope.is_call()) {
-                imports.add("std::boxed::Box as Box_");
-            }
+        if (!destroys.is_empty() || !callbacks.is_empty())
+            && callbacks.iter().any(|c| !c.scope.is_call())
+        {
+            imports.add("std::boxed::Box as Box_");
         }
         if !commented {
             for transformation in &mut parameters.transformations {

diff --git a/src/analysis/trampolines.rs b/src/analysis/trampolines.rs
@@ -69,10 +69,8 @@ pub fn analyze(
 
     //TODO: move to object.signal.return config
     let inhibit = configured_signals.iter().any(|f| f.inhibit);
-    if inhibit {
-        if signal.ret.typ != library::TypeId::tid_bool() {
-            error!("Wrong return type for Inhibit for signal '{}'", signal.name);
-        }
+    if inhibit && signal.ret.typ != library::TypeId::tid_bool() {
+        error!("Wrong return type for Inhibit for signal '{}'", signal.name);
     }
 
     let mut bounds: Bounds = Default::default();