Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Emit rerun-if-changed for branch file on ref: HEAD #1224

Merged
merged 1 commit into from Sep 22, 2021

Conversation

MarijnS95
Copy link
Contributor

We already ran into the issue of git hashes not updating when checked out to a branch, because the HEAD file doesn't change. HEAD does however tell us what branch (ref) the user is checked out to, which is a file much like HEAD containing the hash of the commit it is currently pointing to, and will inevitably change if the user "moves around" (ie. rebasing or committing). Emitting a rerun-if-changed on this file should make the git hash much more reliable.

We already ran into the issue of git hashes not updating when checked
out to a branch, because the `HEAD` file doesn't change.  `HEAD` does
however tell us what branch (ref) the user is checked out to, which is a
file much like `HEAD` containing the hash of the commit it is currently
pointing to, and will inevitably change if the user "moves around" (ie.
rebasing or committing).  Emitting a `rerun-if-changed` on this file
should make the git hash much more reliable.
@sdroege sdroege merged commit 350409c into gtk-rs:master Sep 22, 2021
@MarijnS95 MarijnS95 deleted the git-hash branch September 22, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants