Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analysis: Don't fill imports from virtual methods #1465

Merged
merged 1 commit into from
May 3, 2023
Merged

analysis: Don't fill imports from virtual methods #1465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/analysis/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,14 +211,16 @@ pub fn class(env: &Env, obj: &GObject, deps: &[library::TypeId]) -> Option<Info>

let mut signatures = Signatures::with_capacity(klass.functions.len());

// As we don't generate virtual methods yet, we don't pass imports here
// it would need to be fixed once work in generating virtual methods is done
let virtual_methods = functions::analyze(
env,
&klass.virtual_methods,
Some(class_tid),
true,
false,
obj,
&mut imports,
&mut Imports::default(),
None,
Some(deps),
);
Expand Down