config/codegen: Stop generating useless Display impls #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- objects: It uses to print the type name: not useful at all - enums: It does print what a debug impl would print - flags: It does print what a debug impl would print So just get rid of that generated code and let the bindings generate a display impl manually when it makes sense
|
Note that the special display implementations are kept, if the type has a |
|
Yes keeping those is a good idea. |
|
could it be worth to have a (This can also be a follow up) |
|
Sure, not going to do that though :) it shouldn't be too difficult to add a new config that make the configured function name used in the display impl |
bilelmoussaoui
force-pushed
the
bilelmoussaoui/no-more-display
branch
from
2302c6c
to
f613ce6
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/no-more-display
branch
3 times, most recently
from
8fe7aa3
to
ff23a44
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/no-more-display
branch
from
ff23a44
to
a89a202
Compare
|
should be good to go :) |
sdroege
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So just get rid of that generated code and let the bindings generate a display impl manually when it makes sense