codegen/sys: Don't expect the crates are renamed #1542
Conversation
| for library in &env.config.external_libraries { | ||
| w.write_all( | ||
| format!( | ||
| "use {}_sys as {};\n", |
There was a problem hiding this comment.
Why not just use foo_sys everywhere directly instead of going via the rename?
There was a problem hiding this comment.
I tried to do that, but the whole code is a mess. So for now, I just want a single file to update whenever I do a release
There was a problem hiding this comment.
Ok, so this is just a hack for now to make things work and at a later time the whole renaming should be removed?
Maybe something @GuillaumeGomez wants to look at?
There was a problem hiding this comment.
Ok, so this is just a hack for now to make things work and at a later time the whole renaming should be removed?
Yeah, just going back to the original thing we had
In the past, this seemed like a decent idea but the switch to using cargo workspace proves it wasn't as we now have conflicting crates with the same names
bilelmoussaoui
force-pushed
the
bilelmoussaoui/dont-rename-ffi
branch
from
5c7c1dd
to
55978a6
Compare
|
The CI is expected to fail, the crates have to be adapted |
|
Associated gtk4-rs PR gtk-rs/gtk4-rs#1587 |
In the past, this seemed like a decent idea but the switch to using cargo workspace proves it wasn't as we now have conflicting crates with the same names