doc: allow specifying a separate target path #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduce the amount of manual tweaking required when regenerating the doc of the gstreamer bindings, as it is output in a different path with a different filename. When the option is not specified, the current behaviour is preserved.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-rs
that referenced
this pull request
Feb 9, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new girr feature proposed at gtk-rs/gir#539 to make doc regeneration easier.
EPashkin
reviewed
Feb 9, 2018
| let doc_target_path: PathBuf = match args.get_str("--doc-target-path") { | ||
| "" => { | ||
| match toml.lookup("options.doc_target_path") { | ||
| Some(p) => config_dir.join(try!(p.as_result_str("options.doc_target_path"))), |
There was a problem hiding this comment.
Not sure that it need be relative to config
There was a problem hiding this comment.
Ops, forgot that it really need
|
@MathieuDuponchelle Thanks. allowing specify file name too is good idea. |
|
I was too fast with merge: |
Merged
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-rs
that referenced
this pull request
Feb 12, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new girr feature proposed at gtk-rs/gir#539 to make doc regeneration easier.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-rs
that referenced
this pull request
Feb 12, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new girr feature proposed at gtk-rs/gir#539 to make doc regeneration easier.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-rs
that referenced
this pull request
Feb 12, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new girr feature proposed at gtk-rs/gir#539 to make doc regeneration easier.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-rs
that referenced
this pull request
Feb 12, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new girr feature proposed at gtk-rs/gir#539 to make doc regeneration easier.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-rs
that referenced
this pull request
Feb 12, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new girr feature proposed at gtk-rs/gir#539 to make doc regeneration easier.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-rs
that referenced
this pull request
Feb 12, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new gir feature proposed at gtk-rs/gir#539 to make doc regeneration easier.
sdroege
pushed a commit
to sdroege/gstreamer-rs
that referenced
this pull request
Feb 14, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new gir feature proposed at gtk-rs/gir#539 to make doc regeneration easier. Fixes #80
vhdirk
pushed a commit
to vhdirk/gir
that referenced
this pull request
Jul 6, 2018
doc: allow specifying a separate target path
charlie-ht
pushed a commit
to charlie-ht/gstreamer-rs
that referenced
this pull request
Oct 28, 2018
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new gir feature proposed at gtk-rs/gir#539 to make doc regeneration easier. Fixes sdroege#80
JayDouglass
pushed a commit
to angeleye/gir-files-rs
that referenced
this pull request
Jan 6, 2022
Only automatic bindings for now, which is enough to allow implementing a simple rtsp-server example. Depends on sdroege/gstreamer-sys#8 Uses a new gir feature proposed at gtk-rs/gir#539 to make doc regeneration easier. Fixes sdroege/gstreamer-rs#80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduce the amount of manual tweaking required when
regenerating the doc of the gstreamer bindings, as it is
output in a different path with a different filename.
When the option is not specified, the current behaviour
is preserved.