Use ToOwned and Borrow traits when generating futures. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace cloned() with to_owned() to handle situations where borrowed type is different from the owned one. The cloned() method supports only the case of &T -> T. Borrow trait is used to perform analogous work in other direction.
|
Looks good to me and a bit simpler/more generic indeed. Not sure how I forgot about that 👍 |
|
@tmiasko Thanks, |
vhdirk
pushed a commit
to vhdirk/gir
that referenced
this pull request
Jul 6, 2018
Use ToOwned and Borrow traits when generating futures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace cloned() with to_owned() to handle situations where borrowed
type is different from the owned one. The cloned() method supports only
the case of &T -> T.
Borrow trait is used to perform analogous work in other direction.