Remove all transmute calls in generated code #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@GuillaumeGomez Thanks. |
|
Time to regen everything then! |
This was referenced Apr 10, 2020
Merged
Merged
Merged
Merged
Merged
|
This seems to be wrong: https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/451/diffs#note_462758 |
|
I think this happens here because there are more casts than needed and it happens to cast something wrong. We should probably replace the second |
|
Please open an issue so we can take a look. |
|
See #901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regen sample: gtk-rs/gtk#983
cc @EPashkin @sdroege