Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo_toml: use lib_version_overrides when defining feature versions #940

Merged
merged 1 commit into from
Jun 25, 2020
Merged

cargo_toml: use lib_version_overrides when defining feature versions #940

merged 1 commit into from
Jun 25, 2020

Conversation

gdesmott
Copy link
Contributor

No description provided.

@sdroege
Copy link
Member

sdroege commented Jun 24, 2020

@EPashkin Looks good to you?

@EPashkin
Copy link
Member

@sdroege IMHO this unneeded as collect_versions do it

@sdroege
Copy link
Member

sdroege commented Jun 24, 2020

@EPashkin It's needed for https://gitlab.freedesktop.org/gstreamer/gstreamer-rs-sys/-/merge_requests/61#note_547496

@EPashkin
Copy link
Member

EPashkin commented Jun 24, 2020 •
edited
Loading

@sdroege Then please try .iter instead of .keys

@EPashkin
Copy link
Member

@gdesmott sorry, I missed that PR is your: please try .iter() instead of .keys()

@gdesmott
Copy link
Contributor Author

Indeed, fixed.

@EPashkin
Copy link
Member

@gdesmott Thanks

@EPashkin EPashkin merged commit 30b3c82 into gtk-rs:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdesmott @sdroege @EPashkin