Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

No type-checks in glib::Object::new() for the properties #641

Closed
sdroege opened this issue May 19, 2020 · 1 comment
Closed

No type-checks in glib::Object::new() for the properties #641

sdroege opened this issue May 19, 2020 · 1 comment

Comments

@sdroege
Copy link
Member

sdroege commented May 19, 2020

Should get the same type-checking code as in ObjectExt::set_property() and return an error if values are of the wrong type or out of range.

@sdroege sdroege mentioned this issue May 19, 2020
40 tasks
@sdroege
Copy link
Member Author

sdroege commented May 22, 2020

See #646

GuillaumeGomez pushed a commit to gtk-rs/gtk3-rs that referenced this issue Oct 28, 2020
We didn't check if a property of that name exists or if the given value
is valid for that property. While GObject is doing that itself already,
its type checks are less strict than ours, which caused inconsistencies
with set_property() for example and is simply unexpected.

Fixes gtk-rs/glib#641
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant