This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Ci tests #417
Merged
Ci tests #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Dec 19, 2018
| cargo doc --features "dox"; | ||
| fi | ||
| - if ! [ "$ARM" == "1" ]; then | ||
| cargo test --features "subclassing"; |
sdroege
reviewed
Dec 19, 2018
.travis.yml
Outdated
| - cd _examples | ||
| - ./build_travis.sh | ||
| - if ! [ "$ARM" == "1" ]; then | ||
| git clone -q --depth 50 -b pending https://github.com/gtk-rs/examples _examples; |
There was a problem hiding this comment.
And this also seems useful on ARM
GuillaumeGomez
force-pushed
the
ci-tests
branch
2 times, most recently
from
58dba09
to
8d8e586
Compare
GuillaumeGomez
force-pushed
the
ci-tests
branch
from
8d8e586
to
2158dd1
Compare
EPashkin
reviewed
Dec 19, 2018
| cargo test --features "subclassing"; | ||
| fi | ||
| - if [ "$ARM" == "1" ]; then | ||
| PKG_CONFIG_ALLOW_CROSS=1 cargo build $OTHER_TARGET; |
There was a problem hiding this comment.
Why don't use if with some command with else ?
IMHO this refers to many one-comand "$TRAVIS_OS_NAME" == "osx" too.
There was a problem hiding this comment.
Simply because it's easier to spot errors when reading CI output. Actually, there is a way to have "stages" in travis but I don't have enough time to write a clean CI script for the moment.
|
👍 |
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414.