Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci tests #417

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Dec 19, 2018

Fixes #414.

cargo doc --features "dox";
fi
- if ! [ "$ARM" == "1" ]; then
cargo test --features "subclassing";

This comment has been minimized.

@sdroege

sdroege Dec 19, 2018

Member

Why not run this also on ARM?

.travis.yml Outdated
- cd _examples
- ./build_travis.sh
- if ! [ "$ARM" == "1" ]; then
git clone -q --depth 50 -b pending https://github.com/gtk-rs/examples _examples;

This comment has been minimized.

@sdroege

sdroege Dec 19, 2018

Member

And this also seems useful on ARM

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:ci-tests branch 2 times, most recently from 58dba09 to 8d8e586 Dec 19, 2018

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:ci-tests branch from 8d8e586 to 2158dd1 Dec 19, 2018

cargo test --features "subclassing";
fi
- if [ "$ARM" == "1" ]; then
PKG_CONFIG_ALLOW_CROSS=1 cargo build $OTHER_TARGET;

This comment has been minimized.

@EPashkin

EPashkin Dec 19, 2018

Member

Why don't use if with some command with else ?
IMHO this refers to many one-comand "$TRAVIS_OS_NAME" == "osx" too.

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Dec 19, 2018

Author Member

Simply because it's easier to spot errors when reading CI output. Actually, there is a way to have "stages" in travis but I don't have enough time to write a clean CI script for the moment.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Dec 19, 2018

Seems like it works.

cc @EPashkin @sdroege

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Dec 19, 2018

👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 19, 2018

🎉

@GuillaumeGomez GuillaumeGomez merged commit 318b17c into gtk-rs:master Dec 19, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:ci-tests branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.